Modify

Opened 6 years ago

Closed 6 years ago

#1715 closed Bug/Fehler (fixed)

kein Rabatt auf Attribute bei negativen Attributpreisen

Reported by: info@… Owned by: somebody
Priority: normal Milestone: modified-shop-2.0.5.0
Component: Shop Version: trunk
Keywords: Cc:
Blocked By: Blocking:

Description

Hi,

gibt es einen Grund, dass seit vielen Shop-Generationen der Artikel-Rabatt auf Attribute nicht gewährt wird, wenn der Preisaufschlag des Attributes negativ ist?

Verantwortlich scheinen diese Zeilen:
includes/classes/xtcPrice.php

if ($attribute_data['price_prefix'] == '+') {
        $price = $price - ($price / 100 * $discount);
      } else {
        $price *= -1;
      }

und
includes/modules/product_attributes.php

if ($_SESSION['customers_status']['customers_status_discount_attributes'] == 1 && $products_options['price_prefix'] == '+')
					$price -= $price / 100 * $discount;

Ich würde es wie folgt ändern:
includes/classes/xtcPrice.php

      if ($discount <> 0) {
        $price = $price - ($price / 100 * $discount);
      }
      if ($attribute_data['price_prefix'] == '-') {
        $price *= -1;
      }

und
includes/modules/product_attributes.php

        if ($_SESSION['customers_status']['customers_status_discount_attributes'] == 1 && $discount <> 0) {
          $price -= $price / 100 * $discount;
        }

Viele Grüße
Andreas

Attachments (0)

Change History (1)

comment:1 by Gerhard Waldemair, 6 years ago

Resolution: fixed
Status: newclosed

In 12468:

fix #1715 - fix discount on attributes with negative prices

Modify Ticket

Action
as closed The owner will remain somebody.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.