Modify

Opened 11 years ago

Closed 11 years ago

#470 closed Bug/Fehler (fixed)

Kleine HTML-Fehler in /admin/accounting.php

Reported by: noRiddle Owned by: somebody
Priority: normal Milestone: modified-shop-2.0.0.0
Component: Admin Version: 2.0.0.0
Keywords: Cc:
Blocked By: Blocking:

Description

Die hidden inputs stehen in tr-tags und sollten innerhalb einer Tabelle in td-tags stehen.
Ist nichts großes wird aber moniert und könnte evtl. in späteren Browser-Generationen zu Problemchen führen.
Gut zu sehen mit rechter Maustaste im Firefox, wird dunkel-rot angezeigt.

Attachments (0)

Change History (3)

comment:1 by Ronald Parcinski, 11 years ago

Resolution: closed
Status: newclosed

Kann ich für die derzeitige 2.00 Revision nicht festellen.

comment:2 by Torsten Riemer, 11 years ago

Resolution: closed
Status: closedreopened

Doch... der Fehler ist noch vorhanden!

              if ($field['Field'] != 'customers_id') {
                echo '<tr class="dataTableRow">';
                
                $params = '';
                $checked = false;
                if ($admin_access[$field['Field']] == '1') {
                  $checked = true;
                  if ($_GET['cID'] == '1') {
                    $params = ' disabled="disabled"';
                    echo xtc_draw_hidden_field('access[]', $field['Field']);
                  }
                }

                // colors
                switch ($group_access[$field['Field']]) {
                  case '1':
                    $color='#FF6969';
                    break;
                  case '2':
                    $color='#69CDFF';
                    break;
                  case '3':
                    $color='#6BFF7F';
                    break;
                  case '4':
                    $color='#BFA8FF';
                    break;
                  case '5':
                    $color='#FFE6A8';
                    break;
                }
              
                echo '<td class="dataTableContent" style="width:18px; background:'.$color.';"></td>
                      <td class="dataTableContent" style="width:200px;">'.$field['Field'].'</td>
                      <td class="dataTableContent" colspan="2">'.xtc_draw_checkbox_field('access[]', $field['Field'], $checked, '', $params).'</td>
                    </tr>';
              }

Ergebnis zu sehen im Quelltext der Seite "accounting.php" ab Zeile 230:

            <tr class="dataTableRow"><input type="hidden" name="access[]" value="configuration"><td class="dataTableContent" style="width:18px; background:#FF6969;"></td>
                      <td class="dataTableContent" style="width:200px;">configuration</td>
                      <td class="dataTableContent" colspan="2"><input type="checkbox" name="access[]" value="configuration" checked="checked"  disabled="disabled" class="fmChkBox"></td>
                    </tr><tr class="dataTableRow"><input type="hidden" name="access[]" value="modules"><td class="dataTableContent" style="width:18px; background:#FF6969;"></td>
                      <td class="dataTableContent" style="width:200px;">modules</td>
                      <td class="dataTableContent" colspan="2"><input type="checkbox" name="access[]" value="modules" checked="checked"  disabled="disabled" class="fmChkBox"></td>
                    </tr><tr class="dataTableRow"><input type="hidden" name="access[]" value="countries"><td class="dataTableContent" style="width:18px; background:#FF6969;"></td>
                      <td class="dataTableContent" style="width:200px;">countries</td>
                      <td class="dataTableContent" colspan="2"><input type="checkbox" name="access[]" value="countries" checked="checked"  disabled="disabled" class="fmChkBox"></td>
...
...
...

comment:3 by Ronald Parcinski, 11 years ago

Resolution: fixed
Status: reopenedclosed

In 8206:

fix #470

Modify Ticket

Action
as closed The owner will remain somebody.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.