Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2275 closed Bug/Fehler (fixed)

Fehler in SQL Query in cart_actions.php

Reported by: Stefan May <stefan.may@…> Owned by: somebody
Priority: normal Milestone: modified-shop-2.0.8.0
Component: Shop Version: 2.0.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

Code in /includes/cart_actions.php ab Zeile 385:

              $check_query = xtc_db_query("SELECT COUNT(*) AS cnt, 
                                                  SUM(IF(ISNULL(po.products_options_values_id), 0, 1)) AS checksum 
                                             FROM ".TABLE_ORDERS_PRODUCTS_ATTRIBUTES." opa 
                                        LEFT JOIN ".TABLE_PRODUCTS_OPTIONS_VALUES." as pov
                                                  ON opa.orders_products_options_values_id = pov.products_options_values_id 
                                                     AND pov.language_id = ".(int)$_SESSION['languages_id']." 
                                                     AND pov.products_options_values_id > 0 
                                            WHERE opa.orders_products_id = ".(int)$order_data['ORDERS_PRODUCTS_ID']);

Die angesprochene Tabelle "po" in po.products_options_values_id sollte wahrscheinlich "pov" (für Tabelle products_options_values) sein.
Korrigiert:

              $check_query = xtc_db_query("SELECT COUNT(*) AS cnt, 
                                                  SUM(IF(ISNULL(pov.products_options_values_id), 0, 1)) AS checksum 
                                             FROM ".TABLE_ORDERS_PRODUCTS_ATTRIBUTES." opa 
                                        LEFT JOIN ".TABLE_PRODUCTS_OPTIONS_VALUES." as pov
                                                  ON opa.orders_products_options_values_id = pov.products_options_values_id 
                                                     AND pov.language_id = ".(int)$_SESSION['languages_id']." 
                                                     AND pov.products_options_values_id > 0 
                                            WHERE opa.orders_products_id = ".(int)$order_data['ORDERS_PRODUCTS_ID']);

Attachments (3)

changeset_14646.zip (4.8 KB ) - added by Torsten Riemer 3 years ago.
changeset_14700.zip (4.8 KB ) - added by Torsten Riemer 3 years ago.
changeset_14736.zip (4.8 KB ) - added by Torsten Riemer 3 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 by Stefan May <stefan.may@…>, 3 years ago

Ich sehe gerade, dass der gleiche Codeblock auch noch einmal ab Zeile 469 korrigiert werden muss.

comment:2 by Gerhard Waldemair, 3 years ago

Resolution: fixed
Status: newclosed

In 14646:

fix #2275 - revised r14594 (not adding products from old order to cart when configuration no longer exists)

comment:3 by Gerhard Waldemair, 3 years ago

In 14700:

fix #2275 - revised r14594 (not adding products from old order to cart when configuration no longer exists)

comment:4 by noRiddle, 3 years ago

Gibt's hierzu ein Changeset ? Immerhin ist das ein unangenehmer Fehler wenn ein Kunde im Kundenkonto versucht eine Bestellung zu wiederholen und einfach nur nichts passiert.
Oder ist es mit Änderung von po.* in pov.* wirklich getan (was mir auf den ersten Blick so scheinen will) ?

Gruß,
noRiddle

by Torsten Riemer, 3 years ago

Attachment: changeset_14646.zip added

by Torsten Riemer, 3 years ago

Attachment: changeset_14700.zip added

comment:5 by noRiddle, 3 years ago

Danke. Wollt Ihr die nicht auch im ersten Post des Threads modified eCommerce Shopsoftware 2.0.7.2 rev 14622 veröffentlicht übernehmen ?

Gruß,
noRiddle

comment:6 by Torsten Riemer, 3 years ago

Kann sein, dass wir da nochmal ran müssen, daher warte ich noch.

comment:7 by Gerhard Waldemair, 3 years ago

In 14736:

fix #2275 - revised r14594 (not adding products from old order to cart when configuration no longer exists)

by Torsten Riemer, 3 years ago

Attachment: changeset_14736.zip added

in reply to:  5 comment:8 by Torsten Riemer, 3 years ago

Replying to noRiddle:

Danke. Wollt Ihr die nicht auch im ersten Post des Threads modified eCommerce Shopsoftware 2.0.7.2 rev 14622 veröffentlicht übernehmen ?
[...]

Hiermit erledigt!

Modify Ticket

Action
as closed The owner will remain somebody.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.