Modify

Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#1711 closed Erweiterung (fixed)

Mehrsprachiges Shopvote & Produktbewertungen, Update notwendig

Reported by: noRiddle Owned by: somebody
Priority: normal Milestone: modified-shop-2.0.6.0
Component: Module Version: trunk
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Torsten Riemer)

Aufgrund dessen, daß Shopvote nun mehrsprachig ist könnte/sollte/müsste es eine Anpassung des System-Modules bzgl. var myLanguage geben.
Siehe dazu bitte diesen Post. Mein Vorschlag in dem verlinkten Post ist nur ein vorrübergehender work-around ohne Kenntnisse dessen, was Ihr mit Shopvote für Absprachen treffen können könntet :-D.

Zusätzlich Erweiterung für Produktbewertungen, siehe: NEU: Produktbewertungen sammeln mit SHOPVOTE

Gruß,
noRiddle

Attachments (10)

changeset_12701.zip (6.5 KB ) - added by Torsten Riemer 6 years ago.
changeset_12707.zip (1.1 KB ) - added by Torsten Riemer 6 years ago.
changeset_12710.zip (2.5 KB ) - added by Torsten Riemer 6 years ago.
changeset_12712.zip (2.6 KB ) - added by Torsten Riemer 6 years ago.
changeset_12713.zip (2.5 KB ) - added by Torsten Riemer 6 years ago.
changeset_12714.zip (5.4 KB ) - added by Torsten Riemer 6 years ago.
changeset_12718.zip (4.2 KB ) - added by Torsten Riemer 6 years ago.
changeset_12719.zip (1.3 KB ) - added by Torsten Riemer 6 years ago.
changeset_12727.zip (1.4 KB ) - added by Torsten Riemer 6 years ago.
changeset_12752.zip (1.5 KB ) - added by Torsten Riemer 6 years ago.

Download all attachments as: .zip

Change History (33)

comment:1 by Torsten Riemer, 6 years ago

Component: AdminModule
Description: modified (diff)
Summary: Mehrsprachiges Shopvote, Update notwendigMehrsprachiges Shopvote & Produktbewertungen, Update notwendig
Type: Bug/FehlerErweiterung
Version: trunk

comment:2 by FräuleinGarn, 6 years ago

Vielleicht wäre es auch möglich die Bewertungen nur einmal am Tag abzurufen und den Rest zu cachen, dass nicht bei jedem Seitenaufruf die 18 Skripte und Grafiken geladen werden müssen, die sich in der einen aufzurufenden Datei befinden. Oder die ganzen möglichen Skripte und Grafiken auf dem eigenen Server abzulegen, damit nur noch einmal am Tag die Bewertungen abgerufen werden müssen. Das ganze geht ziemlich auf die Ladegeschwindigkeit der Seite.

comment:3 by noRiddle, 6 years ago

Zumindest die Mehrsprachigkeit wäre eigtl. leicht umzusetzen.
Deshalb erlaube ich mir mal das zu pushen.

Gruß,
noRiddle

comment:4 by noRiddle, 6 years ago

Push again :-D

Gruß,
noRiddle

comment:5 by Torsten Riemer, 6 years ago

Milestone: modified-shop-2.0.5.1

comment:6 by Gerhard Waldemair, 6 years ago

Resolution: fixed
Status: newclosed

In 12701:

fix #1711 - revised Shopvote, including multi language support

by Torsten Riemer, 6 years ago

Attachment: changeset_12701.zip added

comment:8 by FräuleinGarn, 6 years ago

Hier die Fehlermeldung aus mod_warning_2020-04-18.log

Da ist ein Backslash zuviel im Pfad zur modified_api.php

[2020-04-18 23:33:54]	[warning]	[modified]	[pid:16794]	require_once(/var/www/vhosts/meinshop//var/www/vhosts/meinshop/includes/classes/modified_api.php): failed to open stream: No such file or directory in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 25	{}	{}
[2020-04-18 23:33:54]	[warning]	[modified]	[pid:16794]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-18 23:33:54]	[warning]	[modified]	[pid:16794]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}
Last edited 6 years ago by Torsten Riemer (previous) (diff)

comment:9 by FräuleinGarn, 6 years ago

Da ist nicht nur ein Backslash zuviel sondern der erste Teil der Pfadangabe ist doppelt

comment:10 by Torsten Riemer, 6 years ago

Resolution: fixed
Status: closedreopened

Ja, scheint ein Fehler zu sein. Wenn ich das richtig sehe muss es in Datei "/includes/extra/application_top/application_top_end/70_shopvote.php" in Zeile 25 heißen:

      // include needed classes
      require_once (DIR_WS_CLASSES.'modified_api.php');

Anstelle von:

      // include needed classes
      require_once (DIR_FS_CATALOG.DIR_WS_CLASSES.'modified_api.php');

Denn DIR_WS_CLASSES ist laut "/includes/paths.php" bereits so zusammengesetzt:

  // classes
  define('DIR_WS_CLASSES', DIR_WS_INCLUDES . 'classes/');

Und DIR_WS_INCLUDES enthält wiedrum bereits DIR_FS_CATALOG:

  // includes
  define('DIR_WS_INCLUDES', DIR_FS_CATALOG. 'includes/');
Version 0, edited 6 years ago by Torsten Riemer (next)

comment:11 by FräuleinGarn, 6 years ago

Das hatte ich auch schon probiert abgeleitet aus dem PayPal Plus Dateien, wo auch die modified.api eingebunden wird. Das Verhalten im Backend ist das selbe. Keine Texte sichtbar. Die Fehlermeldung mit dem doppelten Pfad und Backslash ist weg.

Dafür kommt nun

[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Illegal string offset 'author' in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 35	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Illegal string offset 'created' in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 36	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Illegal string offset 'author' in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 41	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Illegal string offset 'rating_value' in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 42	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Illegal string offset 'created' in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 43	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Illegal string offset 'text' in File: /var/www/vhosts/meinshop/includes/extra/application_top/application_top_end/70_shopvote.php on Line: 51	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #0 - /var/www/vhosts/meinshop/includes/application_top.php called at Line 363	{}	{}
[2020-04-19 00:27:10]	[warning]	[modified]	[pid:20449]	Backtrace #1 - /var/www/vhosts/meinshop/product_info.php called at Line 25	{}	{}

comment:12 by Gerhard Waldemair, 6 years ago

Resolution: fixed
Status: reopenedclosed

In 12707:

fix #1711 - revised Shopvote, including multi language support

by Torsten Riemer, 6 years ago

Attachment: changeset_12707.zip added

comment:13 by Gerhard Waldemair, 6 years ago

In 12710:

fix #1711 - revised Shopvote, including multi language support

comment:14 by Gerhard Waldemair, 6 years ago

In 12712:

fix #1711 - revised Shopvote, including multi language support

by Torsten Riemer, 6 years ago

Attachment: changeset_12710.zip added

by Torsten Riemer, 6 years ago

Attachment: changeset_12712.zip added

comment:15 by Gerhard Waldemair, 6 years ago

In 12713:

fix #1711 - revised Shopvote, including multi language support

comment:16 by Gerhard Waldemair, 6 years ago

In 12714:

fix #1711 - revised Shopvote, including multi language support

by Torsten Riemer, 6 years ago

Attachment: changeset_12713.zip added

by Torsten Riemer, 6 years ago

Attachment: changeset_12714.zip added

comment:17 by Gerhard Waldemair, 6 years ago

In 12718:

fix #1711 - revised Shopvote, including multi language support

comment:18 by Gerhard Waldemair, 6 years ago

In 12719:

fix #1711 - revised Shopvote, including multi language support

by Torsten Riemer, 6 years ago

Attachment: changeset_12718.zip added

by Torsten Riemer, 6 years ago

Attachment: changeset_12719.zip added

comment:19 by Gerhard Waldemair, 6 years ago

In 12727:

fix #1711 - revised Shopvote, including multi language support

by Torsten Riemer, 6 years ago

Attachment: changeset_12727.zip added

comment:20 by Torsten Riemer, 6 years ago

Milestone: modified-shop-2.0.5.1modified-shop-2.0.5.2

comment:21 by Gerhard Waldemair, 6 years ago

In 12752:

fix #1711 - revised Shopvote, including multi language support

by Torsten Riemer, 6 years ago

Attachment: changeset_12752.zip added

comment:22 by FräuleinGarn, 5 years ago

Seit 2.0.5.1 scheinen keine Bewertungen ohne Text mehr angezeigt zu werden. Dies können nur Bewertungen von Shopvote sein. Bitte lösen, da man sonst umsonst Geld bezahlt bei Shopvote und noch schlimmer bei Inkonsistenz der strukturierten Daten eventuell das Ranking drunter leidet.

comment:23 by Torsten Riemer, 5 years ago

Das wurde bereits in r12757 korrigiert, hat aber mit ShopVote nichts zu tun, siehe: MODUL: ShopVote für Shopversion 2.x

comment:24 by Torsten Riemer, 4 years ago

In 13753:

addition on r12701 (fix #1711 - revised Shopvote, including multi language support)

Modify Ticket

Action
as closed The owner will remain somebody.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.