Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1683 closed Bug/Fehler (fixed)

Kommentare in SQL Queries entfernen

Reported by: Stefan May <stefan@…> Owned by: somebody
Priority: normal Milestone: modified-shop-2.0.5.0
Component: Shop Version: 2.0.4.2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Torsten Riemer)

In Datei shoproot/includes/modules/set_account_type.php findet sich ab Zeile 14:

  $account_type_query = xtc_db_query("-- /includes/application_top.php
                                      SELECT account_type,
                                             customers_default_address_id
                                        FROM ".TABLE_CUSTOMERS."
                                       WHERE customers_id = '".(int) $_SESSION['customer_id']."'");

sowie ab Zeile 23:

    $zone_query = xtc_db_query("-- /includes/application_top.php
                            SELECT entry_country_id
                              FROM ".TABLE_ADDRESS_BOOK."
                             WHERE customers_id='".(int) $_SESSION['customer_id']."'
                               AND address_book_id='".$account_type['customers_default_address_id']."'");

Der String "-- /includes/application_top.php" sollte aus den SQL-Befehlen entfernt werden und jeder Befehl mit dem Schlüsselwort "SELECT" in der jeweils nächsten Zeile beginnen.

In Shopversion 2.0.4.2 ergeben beide SQL-Befehle durch den Fehler immer ein leeres Ergebnis, aber keine Fehlermeldung.

Attachments (0)

Change History (6)

comment:1 by Gerhard Waldemair, 6 years ago

Resolution: worksforme
Status: newclosed

Ich kann das leider nicht nachstellen. Zudem werden SQL Kommentare an vielen weiteren Stellen verwendet. Wir können diese Kommentare gerne entfernen, da ich nie ein Freund davon war.

comment:2 by Gerhard Waldemair, 6 years ago

Milestone: modified-shop-2.0.5.0

comment:4 by Torsten Riemer, 6 years ago

Description: modified (diff)

comment:5 by Torsten Riemer, 6 years ago

Resolution: worksforme
Status: closedreopened
Summary: Code-Fragment in SQL QueryKommentare in SQL Queries entfernen

comment:6 by Gerhard Waldemair, 6 years ago

Resolution: fixed
Status: reopenedclosed

In 12198:

fix #1683 - remove sql comments

comment:7 by Torsten Riemer, 6 years ago

In 12201:

fix #1683 - remove sql comments

Modify Ticket

Action
as closed The owner will remain somebody.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.