Modify

Opened 7 years ago

Closed 7 years ago

#1488 closed Bug/Fehler (fixed)

Bug in Payone-Config

Reported by: noRiddle Owned by: somebody
Priority: normal Milestone: modified-shop-2.0.5.0
Component: Admin Version: 2.0.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

In /admin/payone_config.php wird eine Spalte zu einer DB-Tabelle hinzugefügt mittels folgender Abfrage:

// check new column
$check_query = xtc_db_query("SELECT *
                               FROM payone_transactions
                              LIMIT 1");
$check = xtc_db_fetch_array($check_query);
if (!isset($check['type'])) {
  xtc_db_query("ALTER TABLE payone_transactions ADD type varchar(64) NOT NULL");
}

Das halte ich für äußerst heikel. Die Abfrage sollte per

SHOW COLUMNS FROM payone_transactions

erfolgen.
Was nämlich, wenn es noch keine Zeile in der Tabelle gibt, sie also leer ist ?

Dazu hier in diesem Thread ein User mit einer Fehlermeldung diesbezüglich.

Gruß,
noRiddle

Attachments (0)

Change History (2)

comment:1 by Torsten Riemer, 7 years ago

Milestone: modified-shop-2.0.5.0
Reporter: changed from anonymous to noRiddle
Version: 2.0.4.0

comment:2 by Gerhard Waldemair, 7 years ago

Resolution: fixed
Status: newclosed

In 11331:

fix #1488

Modify Ticket

Action
as closed The owner will remain somebody.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.