id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc	blockedby	blocking
2291	/admin/customers_status.php Performance	noRiddle	somebody	"Da ich auch kleinere Performance-Verbesserungen liebe, ist jedoch nichts Wichtiges:
Der folgende Code könnte in o.g. Datei
{{{
        // adopt customer prices
        if (isset($_POST['customers_base_status']) && !empty($_POST['customers_base_status'])) {
          if ($action == 'save') {
            xtc_db_query('TRUNCATE TABLE personal_offers_by_customers_status_' . $customers_status_id);
          }
          $products_query = xtc_db_query(""SELECT price_id, products_id, quantity, personal_offer FROM personal_offers_by_customers_status_"".(int)$_POST['customers_base_status']."""");
          while($products = xtc_db_fetch_array($products_query)){
            $product_data_array = array(
                'price_id' => xtc_db_prepare_input($products['price_id']),
                'products_id' => xtc_db_prepare_input($products['products_id']),
                'quantity' => xtc_db_prepare_input($products['quantity']),
                'personal_offer' => xtc_db_prepare_input($products['personal_offer'])
              );
            xtc_db_perform('personal_offers_by_customers_status_' . $customers_status_id, $product_data_array);
          }
        }
}}}

könnte so weit effektiver sein (habe kein Benchmark dazu erstellt).
Wenn man sehr viele Artikel hat kann es ansonsten auch mal ins Timeout laufen.
{{{
          // adopt customer prices
          if (isset($_POST['customers_base_status']) && !empty($_POST['customers_base_status'])) {
            if ($action == 'save') {
              xtc_db_query('TRUNCATE TABLE personal_offers_by_customers_status_' . $customers_status_id);
            }
            xtc_db_query(""INSERT INTO personal_offers_by_customers_status_"".$customers_status_id."" SELECT * FROM personal_offers_by_customers_status_"".(int)$_POST['customers_base_status'])
            }
          }
}}}

Wenn nicht, könnte man um der Schönheit willen ;-) in dieser Zeile das überflüssige ."""" am Ende entfernen:
{{{
            $products_query = xtc_db_query(""SELECT price_id, products_id, quantity, personal_offer FROM personal_offers_by_customers_status_"".(int)$_POST['customers_base_status']."""");
}}}



Gruß,
noRiddle"	Aufgabe	closed	normal	modified-shop-2.0.8.0	Admin	2.0.7.2	fixed